Gabriel39 commented on code in PR #12586:
URL: https://github.com/apache/doris/pull/12586#discussion_r970767275
##########
gensrc/thrift/PaloInternalService.thrift:
##########
@@ -175,6 +175,8 @@ struct TQueryOptions {
// For debug purpose, skip delete predicates when reading data
49: optional bool skip_delete_predicate = false
+
+ 50: optional bool enable_new_shuffle_hash_method = true
Review Comment:
how about rename to `enable_xx_hash_shuffle`
##########
be/src/vec/sink/vdata_stream_sender.h:
##########
@@ -316,14 +318,13 @@ class VDataStreamSender::Channel {
bool _enable_local_exchange = false;
};
-template <typename Channels, typename HashVals>
+template <typename Channels>
Status VDataStreamSender::channel_add_rows(Channels& channels, int
num_channels,
- const HashVals& hash_vals, int
rows, Block* block) {
+ uint64_t* __restrict hash_vals, int
rows, Block* block) {
std::vector<int> channel2rows[num_channels];
for (int i = 0; i < rows; i++) {
- auto cid = hash_vals[i] % num_channels;
- channel2rows[cid].emplace_back(i);
+ channel2rows[hash_vals[i]].emplace_back(i);
Review Comment:
`hash_vals` seems not mean hash values. Better to rename it to `channel_ids`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
