HappenLee commented on code in PR #12534:
URL: https://github.com/apache/doris/pull/12534#discussion_r970435706
##########
be/src/runtime/odbc_table_sink.cpp:
##########
@@ -80,8 +80,11 @@ Status OdbcTableSink::send(RuntimeState* state, RowBatch*
batch) {
uint32_t start_send_row = 0;
uint32_t num_row_sent = 0;
while (start_send_row < batch->num_rows()) {
- auto status = _writer->append(_odbc_tbl, batch, start_send_row,
&num_row_sent);
- if (UNLIKELY(!status.ok())) return status;
+ auto status =
+ _writer->append(_odbc_tbl, batch, _output_expr_ctxs,
start_send_row, &num_row_sent);
Review Comment:
use the deinfe RETURN_IF ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
