HappenLee commented on code in PR #12573:
URL: https://github.com/apache/doris/pull/12573#discussion_r969778224
##########
be/src/util/block_compression.cpp:
##########
@@ -368,76 +555,87 @@ class ZlibBlockCompression : public BlockCompressionCodec
{
return Status::OK();
}
- size_t max_compressed_len(size_t len) const override {
+ size_t max_compressed_len(size_t len) override {
// one-time overhead of six bytes for the entire stream plus five
bytes per 16 KB block
return len + 6 + 5 * ((len >> 14) + 1);
}
+
+ bool exceed_max_compress_len(size_t uncompressed_size) override {
+ (void)uncompressed_size;
Review Comment:
the code is unless? why only zlib compress need do override the method ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
