Kikyou1997 commented on code in PR #11805:
URL: https://github.com/apache/doris/pull/11805#discussion_r969263233
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalJoin.java:
##########
@@ -250,4 +250,9 @@ public LEFT_CHILD_TYPE left() {
public RIGHT_CHILD_TYPE right() {
return (RIGHT_CHILD_TYPE) child(1);
}
+
+ public LogicalJoin withHashJoinConjuncts(List<Expression>
hashJoinConjuncts) {
Review Comment:
I think you can add a method named with `withHashJoinConjunctsAndChidren`,
so that you could finish the creation of new JoinNode in one call.
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalJoin.java:
##########
@@ -250,4 +250,9 @@ public LEFT_CHILD_TYPE left() {
public RIGHT_CHILD_TYPE right() {
return (RIGHT_CHILD_TYPE) child(1);
}
+
+ public LogicalJoin withHashJoinConjuncts(List<Expression>
hashJoinConjuncts) {
Review Comment:
I think you could add a method named with `withHashJoinConjunctsAndChidren`,
so that you could finish the creation of new JoinNode in one call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
