zenoyang commented on code in PR #10084: URL: https://github.com/apache/doris/pull/10084#discussion_r969245544
########## be/src/vec/olap/block_reader.cpp: ########## @@ -168,6 +177,49 @@ Status BlockReader::init(const ReaderParams& read_params) { return Status::OK(); } +Status BlockReader::next_block_with_aggregation(Block* block, MemPool* mem_pool, + ObjectPool* agg_pool, bool* eof) { + return _block_aggregator ? _agg_next_block(block, mem_pool, agg_pool, eof) Review Comment: Great suggestion, I've changed it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org