englefly commented on code in PR #12482: URL: https://github.com/apache/doris/pull/12482#discussion_r966799168
########## fe/fe-core/src/main/java/org/apache/doris/nereids/util/TypeCoercionUtils.java: ########## @@ -189,6 +193,10 @@ public static Optional<DataType> findTightestCommonType(DataType left, DataType } } else if (left instanceof CharacterType || right instanceof CharacterType) { tightestCommonType = StringType.INSTANCE; + } else if (left instanceof DecimalType && right instanceof IntegralType) { + tightestCommonType = DecimalType.forType(right); Review Comment: it would be better to add this case as a UT -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org