cambyzju commented on code in PR #12293:
URL: https://github.com/apache/doris/pull/12293#discussion_r965844526
##########
be/src/olap/column_vector.h:
##########
@@ -233,6 +233,13 @@ class ArrayColumnVectorBatch : public ColumnVectorBatch {
*/
void get_offset_by_length(size_t start_idx, size_t size);
+ // From `start_idx`, put `size` ordinals to _item_offsets
+ // Ex:
+ // original _item_offsets: 0 3 5 9; ordinals to be added: 100 105 111;
size: 3; satart_idx: 3
+ // --> _item_offsets: 0 3 5 (9 + 100 - 100) (9 + 105 - 100) (9 + 111 - 100)
+ // _item_offsets becomes 0 3 5 9 14 20
+ void put_item_ordinal(segment_v2::ordinal_t* ordinals, size_t start_idx,
size_t size);
Review Comment:
does push back is enough? it seems we always append ordinals at the end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
