yiguolei commented on code in PR #54760:
URL: https://github.com/apache/doris/pull/54760#discussion_r2281118440
##########
be/src/vec/functions/cast/cast_to_string.h:
##########
@@ -139,30 +139,30 @@ inline void CastToString::push_number(const Int128& num,
ColumnString::Chars& ch
template <>
inline std::string CastToString::from_number(const Float32& num) {
char buf[MAX_FLOAT_STR_LENGTH + 2];
- int len = to_buffer(num, MAX_FLOAT_STR_LENGTH + 2, buf);
+ int len = fast_to_buffer(num, buf);
return std::string(buf, buf + len);
}
template <>
inline void CastToString::push_number(const Float32& num, ColumnString::Chars&
chars) {
char buf[MAX_FLOAT_STR_LENGTH + 2];
- int len = to_buffer(num, MAX_FLOAT_STR_LENGTH + 2, buf);
+ int len = fast_to_buffer(num, buf);
Review Comment:
如果有可能的话，把fast to buffer 移动到这里，并且对外不可见，外部始终调用 casttostring
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
