Gabriel39 commented on code in PR #12407:
URL: https://github.com/apache/doris/pull/12407#discussion_r965006837
##########
be/src/runtime/raw_value.h:
##########
@@ -458,21 +460,6 @@ inline uint32_t RawValue::zlib_crc32(const void* v, const
TypeDescriptor& type,
int len = date_val->to_buffer(buf);
return HashUtil::zlib_crc_hash(buf, len, seed);
}
- case TYPE_DATEV2: {
- const vectorized::DateV2Value<doris::vectorized::DateV2ValueType>*
date_v2_val =
- (const
vectorized::DateV2Value<doris::vectorized::DateV2ValueType>*)v;
- char buf[64];
- int len = date_v2_val->to_buffer(buf);
- return HashUtil::zlib_crc_hash(buf, len, seed);
- }
-
- case TYPE_DATETIMEV2: {
- const vectorized::DateV2Value<doris::vectorized::DateTimeV2ValueType>*
date_v2_val =
- (const
vectorized::DateV2Value<doris::vectorized::DateTimeV2ValueType>*)v;
- char buf[64];
- int len = date_v2_val->to_buffer(buf);
- return HashUtil::zlib_crc_hash(buf, len, seed);
- }
case TYPE_DECIMALV2: {
Review Comment:
collapse `decimalv3` types with the integer types with the same length
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
