Gabriel39 commented on code in PR #12316:
URL: https://github.com/apache/doris/pull/12316#discussion_r962557636
##########
be/src/olap/rowset/beta_rowset_reader.cpp:
##########
@@ -313,6 +314,27 @@ Status BetaRowsetReader::next_block(vectorized::Block*
block) {
return Status::OK();
}
+Status BetaRowsetReader::next_block_view(vectorized::BlockView* block_view) {
+ SCOPED_RAW_TIMER(&_stats->block_fetch_ns);
+ if (config::enable_storage_vectorization && _context->is_vec) {
+ do {
+ auto s = _iterator->next_block_view(block_view);
+ if (!s.ok()) {
+ if (s.is_end_of_file()) {
+ return Status::OLAPInternalError(OLAP_ERR_DATA_EOF);
+ } else {
+ LOG(WARNING) << "failed to read next block: " <<
s.to_string();
+ return
Status::OLAPInternalError(OLAP_ERR_ROWSET_READ_FAILED);
+ }
+ }
+ } while (block_view->empty());
+ } else {
+ return Status::NotSupported("block view only support
enable_storage_vectorization");
Review Comment:
If user set `enable_storage_vectorization` to false, he/she can never
execute sql until turning this to `true` and restart cluster? I think we should
make this more friendly, for example, if `enable_storage_vectorization` is
false, use `next_batch` to do compaction or query execution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
