jackwener commented on code in PR #11976:
URL: https://github.com/apache/doris/pull/11976#discussion_r962506100
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/util/JoinUtils.java:
##########
@@ -169,35 +175,39 @@ public static Pair<List<Expression>, List<Expression>>
extractExpressionForHashT
* Get all used slots from onClause of join.
* Return pair of left used slots and right used slots.
*/
- public static Pair<List<SlotReference>, List<SlotReference>>
getOnClauseUsedSlots(
- AbstractPhysicalJoin<Plan, Plan> join) {
- Pair<List<SlotReference>, List<SlotReference>> childSlots =
+ public static Pair<List<ExprId>, List<ExprId>> getOnClauseUsedSlots(
+ AbstractPhysicalJoin<? extends Plan, ? extends Plan> join) {
+ Pair<List<ExprId>, List<ExprId>> childSlotsExprId =
Pair.of(Lists.newArrayList(), Lists.newArrayList());
List<SlotReference> leftSlots =
Utils.getOutputSlotReference(join.left());
List<SlotReference> rightSlots =
Utils.getOutputSlotReference(join.right());
- List<EqualTo> equalToList = join.getHashJoinConjuncts().stream()
+ List<EqualTo> equalToList = join.getHashJoinConjuncts().stream()
Review Comment:
strange things.
Why `checkstyle` doesn't check this space.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
