starocean999 commented on code in PR #54025:
URL: https://github.com/apache/doris/pull/54025#discussion_r2252900591
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/MVColumnItem.java:
##########
@@ -78,22 +64,13 @@ public MVColumnItem(String name, Type type, AggregateType
aggregateType, boolean
}
}
- public MVColumnItem(String name, Type type) {
- this.name = name;
- this.type = type;
- baseColumnNames = new HashSet<>();
- baseColumnNames.add(name);
- }
-
public MVColumnItem(Expr defineExpr) throws AnalysisException {
- this.name =
CreateMaterializedViewStmt.mvColumnBuilder(defineExpr.toSqlWithoutTbl());
-
- if (this.name == null) {
- throw new AnalysisException("defineExpr.toSql() is null");
- }
-
- this.name = MaterializedIndexMeta.normalizeName(this.name);
+ this(defineExpr.toSqlWithoutTbl(), defineExpr);
+ }
+ public MVColumnItem(String name, Expr defineExpr) throws AnalysisException
{
+ this.name = MaterializedIndexMeta.normalizeName(name);
+ this.isAggregationTypeImplicit = false;
Review Comment:
setAggregationType will update this value later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
