Mryange commented on code in PR #54027:
URL: https://github.com/apache/doris/pull/54027#discussion_r2250304482


##########
be/src/vec/data_types/serde/data_type_array_serde.cpp:
##########
@@ -494,4 +495,52 @@ Status DataTypeArraySerDe::read_column_from_pb(IColumn& 
column, const PValues& a
     }
     return Status::OK();
 }
+
+template <bool is_strict_mode>
+Status DataTypeArraySerDe::_from_string(StringRef& str, IColumn& column,
+                                        const FormatOptions& options) const {
+    if (str.empty()) {
+        return Status::InvalidArgument("slice is empty!");
+    }
+
+    auto& array_column = assert_cast<ColumnArray&>(column);
+    auto& offsets = array_column.get_offsets();
+    IColumn& nested_column = array_column.get_data();
+    DCHECK(nested_column.is_nullable());
+    if (str.front() != '[') {

Review Comment:
   不能,老的解析也是这样的。



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to