morningman commented on code in PR #11742:
URL: https://github.com/apache/doris/pull/11742#discussion_r959362836
##########
be/src/vec/exec/format/parquet/vparquet_reader.cpp:
##########
@@ -79,10 +79,8 @@ Status ParquetReader::_init_read_columns(const
std::vector<SlotDescriptor*>& tup
if (iter != _map_column.end()) {
_include_column_ids.emplace_back(parquet_col_id);
} else {
- std::stringstream str_error;
- str_error << "Invalid Column Name:" << slot_desc->col_name();
- LOG(WARNING) << str_error.str();
- return Status::InvalidArgument(str_error.str());
+ // just continue, as the invalid column will be set to null by
default
Review Comment:
Do we need to set to "default value" if there is a default value when
creating table?
##########
be/src/exec/arrow/arrow_reader.cpp:
##########
@@ -73,12 +73,11 @@ Status ArrowReaderWrap::column_indices(const
std::vector<SlotDescriptor*>& tuple
// Get the Column Reader for the boolean column
auto iter = _map_column.find(slot_desc->col_name());
if (iter != _map_column.end()) {
+ _map_parquet_column_ids_idx[_include_column_ids.size()] = i;
Review Comment:
I think we can use vector for `_map_parquet_column_ids_idx`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
