Jibing-Li commented on code in PR #12048:
URL: https://github.com/apache/doris/pull/12048#discussion_r958718463
##########
be/src/vec/exec/scan/vscan_node.h:
##########
@@ -34,7 +34,9 @@ class VSlotRef;
class VScanNode : public ExecNode {
public:
VScanNode(ObjectPool* pool, const TPlanNode& tnode, const DescriptorTbl&
descs)
- : ExecNode(pool, tnode, descs),
_runtime_filter_descs(tnode.runtime_filters) {}
+ : ExecNode(pool, tnode, descs),
_runtime_filter_descs(tnode.runtime_filters) {
+ _runtime_filter_descs = tnode.runtime_filters;
Review Comment:
I didn't notice it is duplicated. But the wired thing is if I remove this
line, the `_runtime_filter_descs` is not set at all, so that
`_runtime_filter_descs` is empty. I need to double check it.
##########
be/src/vec/exec/scan/vscan_node.h:
##########
@@ -34,7 +34,9 @@ class VSlotRef;
class VScanNode : public ExecNode {
public:
VScanNode(ObjectPool* pool, const TPlanNode& tnode, const DescriptorTbl&
descs)
- : ExecNode(pool, tnode, descs),
_runtime_filter_descs(tnode.runtime_filters) {}
+ : ExecNode(pool, tnode, descs),
_runtime_filter_descs(tnode.runtime_filters) {
+ _runtime_filter_descs = tnode.runtime_filters;
Review Comment:
Double checked, it is duplicated. This line
```_runtime_filter_descs(tnode.runtime_filters)``` was added in your new pr,
will remove the duplicated line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
