wenzhenghu commented on PR #52212:
URL: https://github.com/apache/doris/pull/52212#issuecomment-3135154039

   > I'm not quite clear on the actual significance of tracking the hit counts 
and sizes of small files.From my perspective,we already have the hit rate at 
the CachedRemoteFileReader level(local/total).I understand that this hit rate 
doesn't represent the cache-level hit rate,because cache reads are aligned.In 
fact,I'm skeptical about the necessity of monitoring the cache-level hit 
rate,as this metric seems disconnected from the user experience.If we must add 
it,I think calculating the cache-level hit rate by dividing local hits size by 
total hits size at the cache level would suffice.There's need no for a separate 
tracking of small files.
   > 
   > If you're interested in understanding the general situation of small files 
in the system,I believe we could use the average size derived from the cache 
statistics(cache size divided by the number of cache elements)as a metric to 
gauge the status of small files in the system.
   
   agree, samll hit metrics have deleted


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to