924060929 commented on code in PR #12147:
URL: https://github.com/apache/doris/pull/12147#discussion_r957313265
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/Plan.java:
##########
@@ -43,13 +44,26 @@ public interface Plan extends TreeNode<Plan> {
LogicalProperties getLogicalProperties();
- default LogicalProperties computeLogicalProperties(Plan... inputs) {
+ boolean canResolve();
+
+ default boolean resolved() {
+ return !(getLogicalProperties() instanceof UnboundLogicalProperties);
+ }
+
+ default boolean childrenResolved() {
+ return children()
+ .stream()
+ .map(Plan::getLogicalProperties)
+ .allMatch(p -> !(p instanceof UnboundLogicalProperties));
Review Comment:
Yes, this code is more concise. I wrote this stream first, then wrote the
resolved function and forgot to modify here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
