yiguolei commented on code in PR #51623:
URL: https://github.com/apache/doris/pull/51623#discussion_r2232826529
##########
be/src/olap/rowset/segment_v2/column_reader.cpp:
##########
@@ -666,18 +709,16 @@ Status
ColumnReader::_load_index(std::shared_ptr<IndexFileReader> index_file_rea
}
} else if (is_numeric_type(type)) {
try {
- _index_reader = BkdIndexReader::create_shared(index_meta,
index_file_reader);
+ index_reader = BkdIndexReader::create_shared(index_meta,
index_file_reader);
} catch (const CLuceneError& e) {
return Status::Error<ErrorCode::INVERTED_INDEX_CLUCENE_ERROR>(
"create BkdIndexReader error: {}", e.what());
}
} else {
- _index_reader.reset();
+ return Status::Error<ErrorCode::INVERTED_INDEX_NOT_SUPPORTED>(
+ "Field type {} is not supported for inverted index", type);
}
- // TODO: move has null to inverted_index_reader's query function
- //bool has_null = true;
- //RETURN_IF_ERROR(index_file_reader->has_null(index_meta, &has_null));
- //_inverted_index->set_has_null(has_null);
+ _index_readers[index_meta->index_id()] = index_reader;
Review Comment:
我们当前是每一个column reader 里缓存这个column 相关的所有的index readers 吗？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
