zhannngchen commented on code in PR #12117:
URL: https://github.com/apache/doris/pull/12117#discussion_r956530960
##########
be/src/exec/olap_scanner.cpp:
##########
@@ -152,14 +152,15 @@ Status OlapScanner::_init_tablet_reader_params(
->rowset()
->rowset_meta()
->is_segments_overlapping());
+
+ bool has_replace_col = false;
+ RETURN_IF_ERROR(_init_return_columns(!single_non_overlapping_version,
has_replace_col));
- _tablet_reader_params.direct_mode = single_version || _aggregation;
Review Comment:
The issue here is:
1. Planner thinks scanner can scan directly, don't need merge and can do
some pre-aggregation works.
2. But scanner found it's a unqiue key table with seq column which need to
merge first.
I think we'd better fix it in planner? Planner should not set preAggregation
as true on a unique table with seq column?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
