GoGoWen commented on PR #12081: URL: https://github.com/apache/doris/pull/12081#issuecomment-1228070098
I think it is no need to wrap write/read pidfile into a function, Because seems no elsewhere in our code to use it. camby ***@***.***> 于2022年8月25日周四 22:13写道： > ***@***.**** commented on this pull request. > ------------------------------ > > In be/src/service/doris_main.cpp > <https://github.com/apache/doris/pull/12081#discussion_r955022656>: > > > @@ -488,6 +465,28 @@ int main(int argc, char** argv) { > } > #endif > > + // open pid file, obtain file lock and save pid > > as we need to move the code location, is it better wrap these codes into a > function? > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/doris/pull/12081#pullrequestreview-1085529071>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ATST3BELCDV7XGW3AUDAVPTV255P7ANCNFSM57TEKHYA> > . > You are receiving this because you authored the thread.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
