carlvinhust2012 commented on code in PR #12045:
URL: https://github.com/apache/doris/pull/12045#discussion_r953674794
##########
be/src/vec/columns/column_array.cpp:
##########
@@ -235,7 +235,13 @@ void ColumnArray::insert_from(const IColumn& src_, size_t
n) {
size_t size = src.size_at(n);
size_t offset = src.offset_at(n);
- get_data().insert_range_from(src.get_data(), offset, size);
+ // Note: here we should process the case of
'Nullable(Array(NotNullable(nest)))'
+ if (get_data().is_nullable() && !src.get_data().is_nullable()) {
+ reinterpret_cast<ColumnNullable*>(&get_data())
+ ->insert_range_from_not_nullable(src.get_data(), offset, size);
+ } else {
Review Comment:
if add DCHEC to replace, the insert_from() will just support the only one
case. It is unreasonable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
