This is an automated email from the ASF dual-hosted git repository.

caiconghui pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/master by this push:
     new 2057edbea0 [fix](ut) Fix fe ut npe for DeleteHandlerTest (#12033)
2057edbea0 is described below

commit 2057edbea059b4f618dc8c432c5bac816be3ff17
Author: caiconghui <55968745+caicong...@users.noreply.github.com>
AuthorDate: Wed Aug 24 18:09:02 2022 +0800

    [fix](ut) Fix fe ut npe for DeleteHandlerTest (#12033)
---
 fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java    |  2 +-
 .../test/java/org/apache/doris/load/DeleteHandlerTest.java    | 11 +++++++++++
 2 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java 
b/fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java
index 060a044074..3cfa5d8502 100755
--- a/fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java
@@ -453,7 +453,7 @@ public class Env {
         return journalObservable;
     }
 
-    private SystemInfoService getClusterInfo() {
+    public SystemInfoService getClusterInfo() {
         return this.systemInfo;
     }
 
diff --git 
a/fe/fe-core/src/test/java/org/apache/doris/load/DeleteHandlerTest.java 
b/fe/fe-core/src/test/java/org/apache/doris/load/DeleteHandlerTest.java
index 01311f0754..5c2c005972 100644
--- a/fe/fe-core/src/test/java/org/apache/doris/load/DeleteHandlerTest.java
+++ b/fe/fe-core/src/test/java/org/apache/doris/load/DeleteHandlerTest.java
@@ -43,6 +43,7 @@ import org.apache.doris.mysql.privilege.PaloAuth;
 import org.apache.doris.persist.EditLog;
 import org.apache.doris.qe.ConnectContext;
 import org.apache.doris.qe.QueryStateException;
+import org.apache.doris.system.SystemInfoService;
 import org.apache.doris.task.AgentBatchTask;
 import org.apache.doris.task.AgentTask;
 import org.apache.doris.task.AgentTaskExecutor;
@@ -93,6 +94,8 @@ public class DeleteHandlerTest {
     private AgentTaskQueue agentTaskQueue;
     @Mocked
     private AgentTaskExecutor executor;
+    @Mocked
+    private SystemInfoService systemInfoService;
 
     private Database db;
     private PaloAuth auth;
@@ -167,6 +170,14 @@ public class DeleteHandlerTest {
                 env.getEditLog();
                 minTimes = 0;
                 result = editLog;
+
+                env.getClusterInfo();
+                minTimes = 0;
+                result = systemInfoService;
+
+                systemInfoService.getBackendIds(false);
+                minTimes = 0;
+                result = Lists.newArrayList(1L);
             }
         };
         globalTransactionMgr.addDatabaseTransactionMgr(db.getId());


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to