yiguolei commented on code in PR #11940:
URL: https://github.com/apache/doris/pull/11940#discussion_r953606295
##########
be/src/olap/task/engine_clone_task.cpp:
##########
@@ -324,36 +251,24 @@ Status
EngineCloneTask::_make_and_download_snapshots(DataDir& data_dir,
remote_url_prefix = ss.str();
}
- st = _download_files(&data_dir, remote_url_prefix, local_data_path);
- if (!st.ok()) {
- LOG(WARNING) << "fail to download and convert tablet, remote=" <<
remote_url_prefix
- << ", error=" << st.to_string();
- status = Status::InternalError("Fail to download and convert
tablet");
- // when there is an error, keep this program executing to release
snapshot
- }
+ status = _download_files(&data_dir, remote_url_prefix,
local_data_path);
+ // when there is an error, keep this program executing to release
snapshot
Review Comment:
Losing log here, should print log when download files failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
