924060929 commented on code in PR #11812:
URL: https://github.com/apache/doris/pull/11812#discussion_r953353208
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/physical/PhysicalHashJoin.java:
##########
@@ -38,9 +40,10 @@
RIGHT_CHILD_TYPE extends Plan>
extends AbstractPhysicalJoin<LEFT_CHILD_TYPE, RIGHT_CHILD_TYPE> {
- public PhysicalHashJoin(JoinType joinType, Optional<Expression> condition,
LogicalProperties logicalProperties,
+ public PhysicalHashJoin(JoinType joinType, List<Expression>
hashJoinConjuncts,
+ Optional<Expression> condition, LogicalProperties
logicalProperties,
Review Comment:
change `Optional<Expression> condition` to `List<Expression>
nonHashJoinConjuncts`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
