This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch branch-2.1
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-2.1 by this push:
new 4d59af5aa35 branch-2.1: [fix](job) fix show routine load job result
incorrect after alter job property #53038 (#53094)
4d59af5aa35 is described below
commit 4d59af5aa358c29d3121f1612695213f202a98a0
Author: github-actions[bot]
<41898282+github-actions[bot]@users.noreply.github.com>
AuthorDate: Thu Jul 17 12:16:17 2025 +0800
branch-2.1: [fix](job) fix show routine load job result incorrect after
alter job property #53038 (#53094)
Cherry-picked from #53038
Co-authored-by: hui lai <[email protected]>
---
.../main/java/org/apache/doris/load/routineload/RoutineLoadJob.java | 1 +
regression-test/suites/load_p0/routine_load/test_routine_load.groovy | 4 ++--
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/load/routineload/RoutineLoadJob.java
b/fe/fe-core/src/main/java/org/apache/doris/load/routineload/RoutineLoadJob.java
index edef9358e00..0a62ac3a018 100644
---
a/fe/fe-core/src/main/java/org/apache/doris/load/routineload/RoutineLoadJob.java
+++
b/fe/fe-core/src/main/java/org/apache/doris/load/routineload/RoutineLoadJob.java
@@ -1967,6 +1967,7 @@ public abstract class RoutineLoadJob extends
AbstractTxnStateChangeCallback impl
if
(jobProperties.containsKey(CreateRoutineLoadStmt.MAX_FILTER_RATIO_PROPERTY)) {
this.maxFilterRatio = Double.parseDouble(
jobProperties.remove(CreateRoutineLoadStmt.MAX_FILTER_RATIO_PROPERTY));
+
this.jobProperties.put(CreateRoutineLoadStmt.MAX_FILTER_RATIO_PROPERTY,
String.valueOf(maxFilterRatio));
}
if
(jobProperties.containsKey(CreateRoutineLoadStmt.MAX_BATCH_INTERVAL_SEC_PROPERTY))
{
diff --git
a/regression-test/suites/load_p0/routine_load/test_routine_load.groovy
b/regression-test/suites/load_p0/routine_load/test_routine_load.groovy
index 374688f86ec..c8aef50bc79 100644
--- a/regression-test/suites/load_p0/routine_load/test_routine_load.groovy
+++ b/regression-test/suites/load_p0/routine_load/test_routine_load.groovy
@@ -1740,6 +1740,7 @@ suite("test_routine_load","p0") {
sql "ALTER ROUTINE LOAD FOR ${jobs[i]}
PROPERTIES(\"num_as_string\" = \"true\");"
sql "ALTER ROUTINE LOAD FOR ${jobs[i]}
PROPERTIES(\"fuzzy_parse\" = \"true\");"
sql "ALTER ROUTINE LOAD FOR ${jobs[i]}
PROPERTIES(\"workload_group\" = \"alter_routine_load_group\");"
+ sql "ALTER ROUTINE LOAD FOR ${jobs[i]}
PROPERTIES(\"max_filter_ratio\" = \"0.5\");"
res = sql "show routine load for ${jobs[i]}"
log.info("routine load job properties:
${res[0][11].toString()}".toString())
@@ -1750,8 +1751,7 @@ suite("test_routine_load","p0") {
assertEquals("300001", json.max_batch_rows.toString())
assertEquals("209715201", json.max_batch_size.toString())
assertEquals("6", json.max_batch_interval.toString())
- //TODO(bug): Can not update
- //assertEquals("0.5", json.max_filter_ratio.toString())
+ assertEquals("0.5", json.max_filter_ratio.toString())
assertEquals("jsonpaths", json.jsonpaths.toString())
assertEquals("json_root", json.json_root.toString())
assertEquals("true", json.strict_mode.toString())
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
