[GitHub] [doris] stalary commented on a diff in pull request #11945: [improve](fe): use `Pair.of` to replace `new Pair<>()`

[GitBox]

stalary commented on code in PR #11945:
URL: https://github.com/apache/doris/pull/11945#discussion_r950812804


##########
fe/fe-core/src/main/java/org/apache/doris/common/Pair.java:
##########
@@ -37,41 +38,31 @@
     @SerializedName(value = "second")
     public S second;
 
-    public Pair(F first, S second) {
+    private Pair(F first, S second) {
         this.first = first;
         this.second = second;
     }
 
-    public static <F, S> Pair<F, S> create(F first, S second) {
-        return new Pair<F, S>(first, second);
+    public static <F, S> Pair<F, S> of(F first, S second) {
+        return Pair.of(first, second);

Review Comment:
   endless loop？



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org