morningman commented on code in PR #11450:
URL: https://github.com/apache/doris/pull/11450#discussion_r950678147
##########
be/src/io/fs/s3_file_system.cpp:
##########
@@ -141,7 +141,7 @@ Status S3FileSystem::open_file(const Path& path,
FileReaderSPtr* reader) {
RETURN_IF_ERROR(file_size(path, &fsize));
auto key = get_key(path);
auto fs_path = Path(_s3_conf.endpoint) / _s3_conf.bucket / key;
- *reader = std::make_unique<S3FileReader>(std::move(fs_path), fsize,
std::move(key),
+ *reader = std::make_shared<S3FileReader>(std::move(fs_path), fsize,
std::move(key),
Review Comment:
Why change to shared ?
##########
fe/fe-core/src/main/java/org/apache/doris/common/proc/ReplicasProcNode.java:
##########
@@ -33,12 +33,10 @@
* show replicas' detail info within a tablet
*/
public class ReplicasProcNode implements ProcNodeInterface {
- public static final ImmutableList<String> TITLE_NAMES = new
ImmutableList.Builder<String>()
- .add("ReplicaId").add("BackendId").add("Version")
- .add("LstSuccessVersion").add("LstFailedVersion")
-
.add("LstFailedTime").add("SchemaHash").add("DataSize").add("RowCount").add("State")
-
.add("IsBad").add("VersionCount").add("PathHash").add("MetaUrl").add("CompactionStatus")
- .build();
+ public static final ImmutableList<String> TITLE_NAMES = new
ImmutableList.Builder<String>().add("ReplicaId")
+
.add("BackendId").add("Version").add("LstSuccessVersion").add("LstFailedVersion").add("LstFailedTime")
+
.add("SchemaHash").add("LocalDataSize").add("RowCount").add("State").add("IsBad")
+
.add("VersionCount").add("PathHash").add("MetaUrl").add("CompactionStatus").add("RemoteDataSize").build();
Review Comment:
Add `RemoteDataSize` right after `LocalDataSize`.
##########
fe/fe-core/src/main/java/org/apache/doris/common/proc/TabletsProcDir.java:
##########
@@ -45,9 +45,9 @@ public class TabletsProcDir implements ProcDirInterface {
public static final ImmutableList<String> TITLE_NAMES = new
ImmutableList.Builder<String>()
.add("TabletId").add("ReplicaId").add("BackendId").add("SchemaHash").add("Version")
.add("LstSuccessVersion").add("LstFailedVersion").add("LstFailedTime")
- .add("DataSize").add("RowCount").add("State")
+ .add("LocalDataSize").add("RowCount").add("State")
.add("LstConsistencyCheckTime").add("CheckVersion")
-
.add("VersionCount").add("PathHash").add("MetaUrl").add("CompactionStatus")
+
.add("VersionCount").add("PathHash").add("MetaUrl").add("CompactionStatus").add("RemoteDataSize")
Review Comment:
after `LocalDataSize`
##########
fe/fe-core/src/main/java/org/apache/doris/common/proc/BackendsProcDir.java:
##########
@@ -51,7 +51,7 @@ public class BackendsProcDir implements ProcDirInterface {
.add("BePort").add("HttpPort").add("BrpcPort").add("LastStartTime").add("LastHeartbeat").add("Alive")
.add("SystemDecommissioned").add("ClusterDecommissioned").add("TabletNum")
.add("DataUsedCapacity").add("AvailCapacity").add("TotalCapacity").add("UsedPct")
-
.add("MaxDiskUsedPct").add("Tag").add("ErrMsg").add("Version").add("Status")
+
.add("MaxDiskUsedPct").add("Tag").add("ErrMsg").add("Version").add("Status").add("RemoteUsedCapacity")
Review Comment:
Better to add `RemoteUsedCapacity` right after `DataUsedCapacity`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
