englefly commented on code in PR #11812:
URL: https://github.com/apache/doris/pull/11812#discussion_r950043163
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/physical/AbstractPhysicalJoin.java:
##########
@@ -78,11 +90,27 @@ public boolean equals(Object o) {
return false;
}
AbstractPhysicalJoin that = (AbstractPhysicalJoin) o;
- return joinType == that.joinType && Objects.equals(condition,
that.condition);
+ return joinType == that.joinType && Objects.equals(otherJoinCondition,
that.otherJoinCondition);
Review Comment:
There are equations in `otherJoinCondition`. These equations can not be used
to build hash table, like `t1.a=1`. If the equations can be used to build hash
table, the join must be hash join, not nestedLoopJoin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
