HappenLee commented on code in PR #53084:
URL: https://github.com/apache/doris/pull/53084#discussion_r2203429910
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/ConcatWs.java:
##########
@@ -66,6 +76,18 @@ public boolean nullable() {
@Override
public ConcatWs withChildren(List<Expression> children) {
Preconditions.checkArgument(children.size() >= 2);
+ // 如果第二个及后续参数全是数组类型,则走新签名
+ boolean allArrays = true;
+ for (int i = 1; i < children.size(); ++i) {
+ if (!(children.get(i).getDataType() instanceof ArrayType)) {
+ allArrays = false;
+ break;
+ }
+ }
+ if (allArrays) {
+ return new ConcatWs(children.get(0), children.subList(1,
children.size()));
Review Comment:
maybe here we just do call a array concat is enough
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]