This is an automated email from the ASF dual-hosted git repository.

yiguolei pushed a commit to branch dev-1.1.2
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/dev-1.1.2 by this push:
     new ed06c890ba [fix](memtracker) Fix PartitionedAggregationNode DCHECK 
when mem exceed limit (#11902)
ed06c890ba is described below

commit ed06c890bae161802822c3dcdcbc196c4440aab3
Author: Xinyi Zou <zouxiny...@gmail.com>
AuthorDate: Fri Aug 19 09:56:49 2022 +0800

    [fix](memtracker) Fix PartitionedAggregationNode DCHECK when mem exceed 
limit (#11902)
---
 be/src/exec/partitioned_aggregation_node.cc | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/be/src/exec/partitioned_aggregation_node.cc 
b/be/src/exec/partitioned_aggregation_node.cc
index 614f03ab47..4bccdf67f1 100644
--- a/be/src/exec/partitioned_aggregation_node.cc
+++ b/be/src/exec/partitioned_aggregation_node.cc
@@ -281,8 +281,8 @@ Status PartitionedAggregationNode::open(RuntimeState* 
state) {
                 // Reserve the memory for 'serialize_stream_' so we don't need 
to scrounge up
                 // another buffer during spilling.
                 
RETURN_IF_ERROR(serialize_stream_->PrepareForWrite(&got_buffer));
-                DCHECK(got_buffer)
-                        << "Accounted in min reservation" << 
_buffer_pool_client.DebugString();
+                // DCHECK(got_buffer)
+                //         << "Accounted in min reservation" << 
_buffer_pool_client.DebugString();
                 DCHECK(serialize_stream_->has_write_iterator());
             }
         }
@@ -831,7 +831,7 @@ Status 
PartitionedAggregationNode::Partition::SerializeStreamForSpilling() {
         if (status.ok()) {
             bool got_buffer;
             status = parent->serialize_stream_->PrepareForWrite(&got_buffer);
-            DCHECK(!status.ok() || got_buffer) << "Accounted in min 
reservation";
+            // DCHECK(!status.ok() || got_buffer) << "Accounted in min 
reservation";
         }
         if (!status.ok()) {
             hash_tbl->Close();
@@ -877,8 +877,8 @@ Status PartitionedAggregationNode::Partition::Spill(bool 
more_aggregate_rows) {
         //    
aggregated_row_stream->UnpinStream(BufferedTupleStream3::UNPIN_ALL);
         bool got_buffer;
         RETURN_IF_ERROR(unaggregated_row_stream->PrepareForWrite(&got_buffer));
-        DCHECK(got_buffer) << "Accounted in min reservation"
-                           << parent->_buffer_pool_client.DebugString();
+        // DCHECK(got_buffer) << "Accounted in min reservation"
+        //                    << parent->_buffer_pool_client.DebugString();
     }
 
     COUNTER_UPDATE(parent->num_spilled_partitions_, 1);
@@ -1315,7 +1315,7 @@ Status 
PartitionedAggregationNode::RepartitionSpilledPartition() {
         //    
hash_partition->aggregated_row_stream->UnpinStream(BufferedTupleStream3::UNPIN_ALL);
         bool got_buffer;
         
RETURN_IF_ERROR(hash_partition->unaggregated_row_stream->PrepareForWrite(&got_buffer));
-        DCHECK(got_buffer) << "Accounted in min reservation" << 
_buffer_pool_client.DebugString();
+        // DCHECK(got_buffer) << "Accounted in min reservation" << 
_buffer_pool_client.DebugString();
     }
     
RETURN_IF_ERROR(ProcessStream<false>(partition->unaggregated_row_stream.get()));
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to