This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 8eb9ac3b04 [impovement](sink) print load_id when sink fails (#11893)
8eb9ac3b04 is described below
commit 8eb9ac3b045c61d5eff419fe3556ad398de7a70c
Author: Yongqiang YANG <98214048+dataroar...@users.noreply.github.com>
AuthorDate: Fri Aug 19 08:48:02 2022 +0800
[impovement](sink) print load_id when sink fails (#11893)
---
be/src/exec/tablet_sink.cpp | 11 ++++++-----
be/src/runtime/fragment_mgr.cpp | 7 ++++---
2 files changed, 10 insertions(+), 8 deletions(-)
diff --git a/be/src/exec/tablet_sink.cpp b/be/src/exec/tablet_sink.cpp
index 8993cec7ce..281f94aee2 100644
--- a/be/src/exec/tablet_sink.cpp
+++ b/be/src/exec/tablet_sink.cpp
@@ -83,6 +83,9 @@ Status NodeChannel::init(RuntimeState* state) {
_node_info = *node;
+ _load_info = "load_id=" + print_id(_parent->_load_id) +
+ ", txn_id=" + std::to_string(_parent->_txn_id);
+
_row_desc.reset(new RowDescriptor(_tuple_desc, false));
_batch_size = state->batch_size();
@@ -90,7 +93,7 @@ Status NodeChannel::init(RuntimeState* state) {
_node_info.brpc_port);
if (_stub == nullptr) {
LOG(WARNING) << "Get rpc stub failed, host=" << _node_info.host
- << ", port=" << _node_info.brpc_port;
+ << ", port=" << _node_info.brpc_port << ", " <<
channel_info();
_cancelled = true;
return Status::InternalError("get rpc stub failed");
}
@@ -112,8 +115,6 @@ Status NodeChannel::init(RuntimeState* state) {
_timeout_watch.start();
_max_pending_batches_bytes = _parent->_load_mem_limit / 20; //TODO:
session variable percent
- _load_info = "load_id=" + print_id(_parent->_load_id) +
- ", txn_id=" + std::to_string(_parent->_txn_id);
return Status::OK();
}
@@ -153,7 +154,7 @@ void NodeChannel::open() {
}
void NodeChannel::_cancel_with_msg(const std::string& msg) {
- LOG(WARNING) << msg;
+ LOG(WARNING) << channel_info() << ", " << msg;
{
std::lock_guard<SpinLock> l(_cancel_msg_lock);
if (_cancel_msg == "") {
@@ -176,7 +177,7 @@ Status NodeChannel::open_wait() {
ss << "failed to open tablet writer, error=" <<
berror(_open_closure->cntl.ErrorCode())
<< ", error_text=" << _open_closure->cntl.ErrorText();
_cancelled = true;
- LOG(WARNING) << ss.str();
+ LOG(WARNING) << ss.str() << " " << channel_info();
return Status::InternalError("failed to open tablet writer, error={},
error_text={}",
berror(_open_closure->cntl.ErrorCode()),
_open_closure->cntl.ErrorText());
diff --git a/be/src/runtime/fragment_mgr.cpp b/be/src/runtime/fragment_mgr.cpp
index b2f00c862d..7b60e9d406 100644
--- a/be/src/runtime/fragment_mgr.cpp
+++ b/be/src/runtime/fragment_mgr.cpp
@@ -304,7 +304,8 @@ void FragmentExecState::coordinator_callback(const Status&
status, RuntimeProfil
FrontendServiceConnection coord(_exec_env->frontend_client_cache(),
_coord_addr, &coord_status);
if (!coord_status.ok()) {
std::stringstream ss;
- ss << "couldn't get a client for " << _coord_addr;
+ ss << "couldn't get a client for " << _coord_addr << ", reason: " <<
coord_status;
+ LOG(WARNING) << "query_id: " << _query_id << ", " << ss.str();
update_status(Status::InternalError(ss.str()));
return;
}
@@ -391,8 +392,8 @@ void FragmentExecState::coordinator_callback(const Status&
status, RuntimeProfil
TReportExecStatusResult res;
Status rpc_status;
- VLOG_ROW << "debug: reportExecStatus params is "
- << apache::thrift::ThriftDebugString(params).c_str();
+ VLOG_DEBUG << "reportExecStatus params is "
+ << apache::thrift::ThriftDebugString(params).c_str();
try {
try {
coord->reportExecStatus(res, params);
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
