whutpencil commented on code in PR #11793:
URL: https://github.com/apache/doris/pull/11793#discussion_r946563717


##########
fs_brokers/apache_hdfs_broker/src/main/java/org/apache/doris/broker/hdfs/FileSystemManager.java:
##########
@@ -394,7 +394,6 @@ public BrokerFileSystem getS3AFileSystem(String path, 
Map<String, String> proper
         String disableCache = 
properties.getOrDefault(FS_S3A_IMPL_DISABLE_CACHE, "true");
         String s3aUgi = accessKey + "," + secretKey;
         FileSystemIdentity fileSystemIdentity = new FileSystemIdentity(host, 
s3aUgi);
-        cachedFileSystem.putIfAbsent(fileSystemIdentity, new 
BrokerFileSystem(fileSystemIdentity));

Review Comment:
   @morningman Because this step has been done in the updateCachedFileSystem 
method in the next line of code, this line of code is redundant.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to