spaces-X commented on code in PR #11782: URL: https://github.com/apache/doris/pull/11782#discussion_r945560043
########## fe/fe-core/src/main/java/org/apache/doris/analysis/AggregateInfo.java: ########## @@ -160,6 +161,15 @@ public void setPartitionExprs(List<Expr> exprs) { partitionExprs = exprs; } + private static void validateGroupingExprs(List<Expr> groupingExprs) throws AnalysisException { Review Comment: I think it is more reasonable to put this checking logic into `GroupByClause`'s analyze phase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org