wangbo commented on code in PR #11754:
URL: https://github.com/apache/doris/pull/11754#discussion_r945225567
##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -1199,6 +1199,34 @@ Status SegmentIterator::next_batch(vectorized::Block*
block) {
return Status::OK();
}
+void SegmentIterator::_convert_dict_code_for_predicate_if_necessary() {
+ for (auto predicate : _short_cir_eval_predicate) {
+ _convert_dict_code_for_predicate_if_necessary_impl(predicate);
+ }
+
+ for (auto predicate : _pre_eval_block_predicate) {
+ _convert_dict_code_for_predicate_if_necessary_impl(predicate);
+ }
+
+ std::set<const ColumnPredicate*> predicate_set {};
+ _opts.delete_condition_predicates->get_all_column_predicate(predicate_set);
Review Comment:
How about keep predicate_set as field of SegmentIterator so we don't need
get them for every batch?
We can get the info that which Predicate is range and its id including
delete pred or non-predicate in ```_vec_init_lazy_materialization```, then in
```_convert_dict_code_for_predicate_if_necessary``` we just get id and exec
```convert_dict_codes_if_necessary```.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
