morningman commented on code in PR #11625:
URL: https://github.com/apache/doris/pull/11625#discussion_r945214836
##########
fe/fe-core/src/main/java/org/apache/doris/task/StreamLoadTask.java:
##########
@@ -320,6 +328,9 @@ private void
setOptionalFromTSLPutRequest(TStreamLoadPutRequest request) throws
if (request.isSetLoadToSingleTablet()) {
loadToSingleTablet = request.isLoadToSingleTablet();
}
+ if (request.isSetHiddenColumns()) {
+ hiddenColumns =
Arrays.asList(request.getHiddenColumns().split(","));
Review Comment:
Need to trim the space, eg:
`"delete, sequence" => "delete,sequence"`
##########
docs/en/docs/sql-manual/sql-reference/Data-Manipulation-Statements/Load/STREAM-LOAD.md:
##########
@@ -136,6 +136,14 @@ Parameter introduction:
21. send_batch_parallelism: Integer, used to set the parallelism of sending
batch data. If the value of parallelism exceeds
`max_send_batch_parallelism_per_job` in the BE configuration, the BE as a
coordination point will use the value of `max_send_batch_parallelism_per_job`.
+22. hidden_columns: Specify hidden column when no `columns` in Headers，multi
hidden column shoud be
+separated by commas。
+
+ ```
+ hidden_columns: __DORIS_DELETE_SIGN__
Review Comment:
Please also give the example for `__DORIS_SEQUENCE_COL__`.
Or use may not known the name of this hidden column.
And the following header will result in different:
```
hidden_columns: __DORIS_DELETE_SIGN__,__DORIS_SEQUENCE_COL__
hidden_columns: __DORIS_SEQUENCE_COL__,__DORIS_DELETE_SIGN__
```
My suggestion is:
1. User can specify the hidden columns in different order.
2. The system will reorder the hidden columns specified by user, put
`__DORIS_DELETE_SIGN__` at first and `__DORIS_SEQUENCE_COL__` at last.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
