xinyiZzz commented on code in PR #11748:
URL: https://github.com/apache/doris/pull/11748#discussion_r945016513
##########
be/src/olap/schema_change.cpp:
##########
@@ -1356,11 +1356,16 @@ Status
SchemaChangeWithSorting::_inner_process(RowsetReaderSharedPtr rowset_read
RowBlock* ref_row_block = nullptr;
rowset_reader->next_block(&ref_row_block);
while (ref_row_block != nullptr && ref_row_block->has_remaining()) {
- if (!_row_block_allocator->allocate(&new_row_block,
ref_row_block->row_block_info().row_num,
- true)) {
+ auto st = _row_block_allocator->allocate(&new_row_block,
+
ref_row_block->row_block_info().row_num, true);
+ // if OLAP_ERR_INPUT_PARAMETER_ERROR == st.precise_code()
+ // that mean RowBlockAllocator::alocate() memory exceeded.
+ // But we can flush row_block_arr if row_block_arr is not empty.
+ // Don't return directly.
+ if (OLAP_ERR_MALLOC_ERROR == st.precise_code()) {
LOG(WARNING) << "failed to allocate RowBlock.";
Review Comment:
log print duplicate
`LOG(WARNING) << "failed to allocate RowBlock.";` has been printed in
schema_change.cpp:980
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
