hqx871 commented on code in PR #11579:
URL: https://github.com/apache/doris/pull/11579#discussion_r944998861


##########
fe/fe-core/src/main/java/org/apache/doris/analysis/IndexDef.java:
##########
@@ -142,6 +217,30 @@ public void checkColumn(Column column, KeysType keysType) 
throws AnalysisExcepti
                         "BITMAP index only used in columns of 
DUP_KEYS/UNIQUE_KEYS table or key columns of"
                                 + " AGG_KEYS table. invalid column: " + 
indexColName);
             }
+        } else if (indexType == IndexType.NGRAM_BF) {
+            String indexColName = column.getName();
+            PrimitiveType colType = column.getDataType();
+            if (colType != PrimitiveType.CHAR && colType != 
PrimitiveType.VARCHAR) {

Review Comment:
   you are right. but i will change to colType.isCharFamily(), as isStringType 
includes hll type.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to