morningman commented on code in PR #11695:
URL: https://github.com/apache/doris/pull/11695#discussion_r943439956
##########
be/src/vec/exec/volap_scan_node.cpp:
##########
@@ -879,9 +879,11 @@ Status
VOlapScanNode::change_value_range(ColumnValueRange<PrimitiveType>& temp_r
}
bool VOlapScanNode::is_key_column(const std::string& key_name) {
- // all column in dup_keys table olap scan node threat
+ // all column in dup_keys table or unique_keys with merge on write table
olap scan node threat
// as key column
- if (_olap_scan_node.keyType == TKeysType::DUP_KEYS) {
+ if (_olap_scan_node.keyType == TKeysType::DUP_KEYS ||
+ (_olap_scan_node.keyType == TKeysType::UNIQUE_KEYS &&
+ _olap_scan_node.enable_unique_key_merge_on_write)) {
Review Comment:
need to check if `enable_unique_key_merge_on_write` is set first.
for forward compatibility
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
