zhannngchen commented on code in PR #11664:
URL: https://github.com/apache/doris/pull/11664#discussion_r943437599


##########
fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java:
##########
@@ -2890,6 +2890,12 @@ public static void getDdlStmt(DdlStmt ddlStmt, String 
dbName, TableIf table, Lis
                 sb.append(olapTable.getCompressionType()).append("\"");
             }
 
+            // unique key table with merge on write
+            if (olapTable.getKeysType() == KeysType.UNIQUE_KEYS) {

Review Comment:
   if (lapTable.getEnableUniqueKeyMergeOnWrite())



##########
fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java:
##########
@@ -2890,6 +2890,12 @@ public static void getDdlStmt(DdlStmt ddlStmt, String 
dbName, TableIf table, Lis
                 sb.append(olapTable.getCompressionType()).append("\"");
             }
 
+            // unique key table with merge on write
+            if (olapTable.getKeysType() == KeysType.UNIQUE_KEYS) {
+                
sb.append(",\n\"").append(PropertyAnalyzer.ENABLE_UNIQUE_KEY_MERGE_ON_WRITE).append("\"
 = \"");
+                sb.append(olapTable.getEnableUniqueKeyMergeOnWrite() ? "true" 
: "false").append("\"");

Review Comment:
   `append(olapTable.getEnableUniqueKeyMergeOnWrite()) ` would work.



##########
fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java:
##########
@@ -2890,6 +2890,12 @@ public static void getDdlStmt(DdlStmt ddlStmt, String 
dbName, TableIf table, Lis
                 sb.append(olapTable.getCompressionType()).append("\"");
             }
 
+            // unique key table with merge on write
+            if (olapTable.getKeysType() == KeysType.UNIQUE_KEYS) {

Review Comment:
   if user not set the property, we should not show it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to