CalvinKirs commented on code in PR #52264:
URL: https://github.com/apache/doris/pull/52264#discussion_r2165429721
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/hive/HMSExternalCatalog.java:
##########
@@ -161,25 +160,13 @@ protected synchronized void
initPreExecutionAuthenticator() {
@Override
protected void initLocalObjectsImpl() {
initPreExecutionAuthenticator();
- HiveConf hiveConf = null;
- JdbcClientConfig jdbcClientConfig = null;
- String hiveMetastoreType =
catalogProperty.getOrDefault(HMSProperties.HIVE_METASTORE_TYPE, "");
- if (hiveMetastoreType.equalsIgnoreCase("jdbc")) {
- jdbcClientConfig = new JdbcClientConfig();
Review Comment:
I didn’t validate whether the user input still includes any JDBC references,
but I think that’s fine in this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
