yangzhg commented on code in PR #11629: URL: https://github.com/apache/doris/pull/11629#discussion_r942031469
########## be/src/io/cache/whole_file_cache.cpp: ########## @@ -37,6 +37,16 @@ WholeFileCache::~WholeFileCache() {} Status WholeFileCache::read_at(size_t offset, Slice result, size_t* bytes_read) { if (_cache_file_reader == nullptr) { + std::lock_guard<std::shared_mutex> wrlock(_cache_lock); Review Comment: why create cache dir when read ?and why use shared_mutex here ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org