Kikyou1997 opened a new pull request, #11621:
URL: https://github.com/apache/doris/pull/11621
# Proposed changes
Issue Number: noissue
## Problem summary
1. Set source expr for the slotDescrptor of inlineView, so that we could
mark the slot in the lower level as materialzied when we do the column prune in
the logic of `materializeInlineViewResultExprForCrossJoinOrCountStar`
2. Delay the deletion for not materialized slot in the resolvedTupleExprs in
the SortNode, so that we could make sure those slot which would be materialized
in the logic of `materializeInlineViewResultExprForCrossJoinOrCountStar` could
be add to the resolvedTupleExprs as the output of the SortNode
3. Remove some useless field in the AggregateInfo which always bother and
make developer confused when reading code
Besides, this PR will also change the nullability inference of the
CreateTableAsSelectStmt, since the nullability of created table is determined
by the srcExpr first, if there doesn't exist srcExpr, then will use the
nullability of the SlotRef itself, in the past, this srcExpr of tuple created
for InlineView is always null, but now we set it.
You can learn these affected logic in the below methods:
* InternalDataSource# createTableAsSelect
* Expr#getSrcSlotRef
## Checklist(Required)
1. Does it affect the original behavior:
- [x] Yes
- [ ] No
- [ ] I don't know
4. Has unit tests been added:
- [ ] Yes
- [x] No
- [ ] No Need
5. Has document been added or modified:
- [ ] Yes
- [ ] No
- [x] No Need
6. Does it need to update dependencies:
- [ ] Yes
- [x] No
7. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [x] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you
chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
