wuyunfeng commented on code in PR #11340: URL: https://github.com/apache/doris/pull/11340#discussion_r939796674
########## fe/fe-core/src/main/java/org/apache/doris/external/elasticsearch/EsUtil.java: ########## @@ -132,16 +133,33 @@ public static boolean getBoolean(Map<String, String> properties, String name) th } } - /** - * Get mapping properties JSONObject. - **/ - public static JSONObject getMappingProps(String sourceIndex, String indexMapping, String mappingType) { + public static List<String> getArrayFields(String indexMapping) { + JSONObject mappings = getMapping(indexMapping); + if (!mappings.containsKey("_meta")) { + return new ArrayList<>(); + } + JSONObject meta = (JSONObject) mappings.get("_meta"); + if (!meta.containsKey("doris")) { + return new ArrayList<>(); + } + JSONObject dorisMeta = (JSONObject) meta.get("doris"); Review Comment: i do not think add the name `doris`to Ealsticsearch index meta is suitable -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org