yiguolei commented on code in PR #51766:
URL: https://github.com/apache/doris/pull/51766#discussion_r2153496832
##########
be/src/vec/data_types/data_type_jsonb.cpp:
##########
@@ -70,6 +71,26 @@ Status DataTypeJsonb::from_string(ReadBuffer& rb, IColumn*
column) const {
return Status::OK();
}
+Field DataTypeJsonb::get_default() const {
+ std::string default_json = "null";
+ // convert default_json to binary
+ JsonBinaryValue jsonb_value;
+ THROW_IF_ERROR(jsonb_value.from_json_string(default_json));
Review Comment:
I prefer not change this logic. Keep the logic the same with the original
logic in header file.
If we want to change this logic, pls submit another PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
