dataroaring commented on code in PR #11169:
URL: https://github.com/apache/doris/pull/11169#discussion_r937383846
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/ShowAlterStmt.java:
##########
@@ -104,12 +104,13 @@ private void getPredicateValue(Expr subExpr) throws
AnalysisException {
if (!(subExpr instanceof BinaryPredicate)) {
throw new AnalysisException("The operator =|>=|<=|>|<|!= are
supported.");
}
+ LOG.info("enter getPredicateValue");
Review Comment:
remove the log
##########
fe/fe-core/src/main/java/org/apache/doris/common/util/TimeUtils.java:
##########
@@ -149,13 +152,22 @@ public static String longToTimeString(long timeStamp,
SimpleDateFormat dateForma
return dateFormat.format(new Date(timeStamp));
}
- public static String longToTimeString(long timeStamp) {
- SimpleDateFormat datetimeFormatTimeZone =
datetimeFormatThreadLocal.get();
+ public static String longToTimeStringProc(long timeStamp, SimpleDateFormat
datetimeFormatTimeZone) {
Review Comment:
longToTimeStringProc, the name is a little strange. Maybe we can rename it
to longToTimeStringWithFormat?
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/InternalDataSource.java:
##########
@@ -1731,6 +1726,26 @@ private void createOlapTable(Database db,
CreateTableStmt stmt) throws UserExcep
// this should be done before create partition.
Map<String, String> properties = stmt.getProperties();
+ // get use light schema change
+ Boolean useLightSchemaChange = true;
+ try {
+ useLightSchemaChange =
PropertyAnalyzer.analyzeUseLightSchemaChange(properties);
+ } catch (AnalysisException e) {
+ throw new DdlException(e.getMessage());
+ }
+ // use light schema change optimization
+ olapTable.setUseLightSchemaChange(useLightSchemaChange);
+ if (useLightSchemaChange) {
+ LOG.info("table: {} uses light schema change",
olapTable.getName());
Review Comment:
LOG.debug is enough.
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/InternalDataSource.java:
##########
@@ -1731,6 +1726,26 @@ private void createOlapTable(Database db,
CreateTableStmt stmt) throws UserExcep
// this should be done before create partition.
Map<String, String> properties = stmt.getProperties();
+ // get use light schema change
+ Boolean useLightSchemaChange = true;
Review Comment:
default should be false？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
