cambyzju commented on code in PR #11213: URL: https://github.com/apache/doris/pull/11213#discussion_r937314351
########## be/src/vec/functions/function_string.h: ########## @@ -1437,4 +1438,22 @@ class FunctionReplace : public IFunction { } }; +struct ReverseImpl { + static Status vector(const ColumnString::Chars& data, const ColumnString::Offsets& offsets, + ColumnString::Chars& res_data, ColumnString::Offsets& res_offsets) { + auto rows_count = offsets.size(); Review Comment: impl codes put into cpp file -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org