[GitHub] [doris] caiconghui commented on a diff in pull request #11479: [Enhancement](IdGenerator) Use IdGeneratorBuffer to get better performance for getNextId operation when create table, truncate table, add partition and so on

[GitBox]

caiconghui commented on code in PR #11479:
URL: https://github.com/apache/doris/pull/11479#discussion_r937285824


##########
fe/fe-core/src/main/java/org/apache/doris/datasource/InternalDataSource.java:
##########
@@ -2073,7 +2082,6 @@ private void createOdbcTable(Database db, CreateTableStmt 
stmt) throws DdlExcept
             ErrorReport.reportDdlException(ErrorCode.ERR_TABLE_EXISTS_ERROR, 
tableName);
         }
         LOG.info("successfully create table[{}-{}]", tableName, tableId);
-        return;
     }
 
     private Table createEsTable(Database db, CreateTableStmt stmt) throws 
DdlException {

Review Comment:
   may be solved in other PR, it cost long time to run pipeline test 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org