yiguolei commented on code in PR #11474: URL: https://github.com/apache/doris/pull/11474#discussion_r936578677
########## be/src/olap/rowset/segment_v2/segment_iterator.h: ########## @@ -165,9 +165,9 @@ class SegmentIterator : public RowwiseIterator { const Schema& _schema; // _column_iterators.size() == _schema.num_columns() // _column_iterators[cid] == nullptr if cid is not in _schema - std::vector<ColumnIterator*> _column_iterators; + std::map<int32_t, ColumnIterator*> _column_iterators; // FIXME prefer vector<unique_ptr<BitmapIndexIterator>> Review Comment: modify the comments and explain the map structure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org