yiguolei commented on code in PR #50817:
URL: https://github.com/apache/doris/pull/50817#discussion_r2128858639
##########
be/src/runtime/load_channel.cpp:
##########
@@ -59,7 +59,9 @@ LoadChannel::LoadChannel(const UniqueId& load_id, int64_t
timeout_s, bool is_hig
_resource_ctx->memory_context()->set_mem_tracker(mem_tracker);
WorkloadGroupPtr wg_ptr = nullptr;
if (wg_id > 0) {
- wg_ptr =
ExecEnv::GetInstance()->workload_group_mgr()->get_group(wg_id);
+ std::vector<uint64_t> id_set;
+ id_set.push_back(wg_id);
+ wg_ptr =
ExecEnv::GetInstance()->workload_group_mgr()->get_group(id_set);
if (wg_ptr != nullptr) {
_resource_ctx->set_workload_group(wg_ptr);
}
Review Comment:
似乎我们get group 方法永远不会返回空，所以这个if 没什么用啊
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
