zddr commented on code in PR #50942:
URL: https://github.com/apache/doris/pull/50942#discussion_r2123492431


##########
fe/fe-core/src/main/java/org/apache/doris/job/base/AbstractJob.java:
##########
@@ -265,6 +265,15 @@ public void initTasks(Collection<? extends T> tasks, 
TaskType taskType) {
         this.startTimeMs = System.currentTimeMillis();
     }
 
+    /**
+     * Some of the logic does not satisfy idempotency—each job can only be 
called once.
+     */
+    public void initParams() {
+        if (jobConfig != null) {

Review Comment:
   This method is only called once during initialization, so there are no 
thread-safety concerns.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to